Build date: 1736636403 - Sat Jan 11 23:00:03 UTC 2025 Build cvs date: 1736630439 - Sat Jan 11 21:20:39 UTC 2025 Build id: 2025-01-12.1 Build tags: amd64-regress ports sysupgrade Applied the following diff(s): /home/anton/tmp/robsd/src-regress-sys-netinet6-rip6cksum.diff /home/anton/tmp/robsd/src-sys-em.diff /home/anton/tmp/robsd/src-sys-newvers.diff /home/anton/tmp/robsd/src-sys-uhidev-sispm.diff /home/anton/tmp/robsd/src-sysupgrade.diff P lib/libcrypto/asn1/t_x509.c P lib/libcrypto/ec/ec_key.c P lib/libcrypto/ec/ec_lib.c P lib/libcrypto/ec/ec_local.h P lib/libcrypto/ec/ec_mult.c P lib/libcrypto/ec/ecp_methods.c P sbin/nfsd/nfsd.c P sys/dev/ic/ufshci.c P sys/dev/ic/ufshcivar.h commit 9wMYCmx8ERDXbEy5 Author: tb Date: 2025/01/11 21:20:39 Fix another awful comment in ec_point_cmp() lib/libcrypto/ec/ecp_methods.c commit x9FjU7neVY0FekV0 Author: tb Date: 2025/01/11 21:13:21 Align vertical backslashes in a macro lib/libcrypto/ec/ecp_methods.c commit vn00dvlkGFg2pgvt Author: tb Date: 2025/01/11 21:07:25 ec_point_cmp: tidy up an ugly comment lib/libcrypto/ec/ecp_methods.c commit jRwPDZ4lO39uz1L9 Author: tb Date: 2025/01/11 20:57:03 ec_key_gen() is unused outside ec_key.c, so make it static lib/libcrypto/ec/ec_key.c lib/libcrypto/ec/ec_local.h commit jUnSuCVc4GeHJMYq Author: tb Date: 2025/01/11 20:55:08 Move EC_KEY_METHOD_DYNAMIC next to the two methods using it Only EC_KEY_METHOD_{new,free}() need to know about this flag, so make that more obvious. lib/libcrypto/ec/ec_key.c lib/libcrypto/ec/ec_local.h commit 9SrwVKZ4XzkWWYvz Author: mglocker Date: 2025/01/11 20:48:27 Debug level 3 got too noisy, and leaves the system back almost unusable when enabled. Therefore, remove some of the noisiest level 3 messages. Instead, introduce a timeout print function for level 3, which shows information about the CCB slot utilization, and whether we have stalled CCBs in the driver. sys/dev/ic/ufshci.c sys/dev/ic/ufshcivar.h commit kK1unw4qcxm2OYSq Author: kn Date: 2025/01/11 18:21:02 zap dead poll code With TCP on/off connect_type_cnt is 1/0; it can't be >=2 since 2004 r1.24 "remove iso crud, and other misc cleanups", so remove the unreachable block and flip early-exit logic to decrease indentation. OK millert sbin/nfsd/nfsd.c commit yYQsmOMgHWLs2XmE Author: tb Date: 2025/01/11 15:32:36 Remove a weird comment lib/libcrypto/ec/ec_local.h commit w4PItFkvWG1myj8d Author: tb Date: 2025/01/11 15:26:07 Rename the is_on_curve() method to point_is_on_curve() Rename ec_is_on_curve() to ec_point_is_on_curve() and ec_cmp() to ec_point_cmp(). lib/libcrypto/ec/ec_lib.c lib/libcrypto/ec/ec_local.h lib/libcrypto/ec/ecp_methods.c commit juT2hWaejcA5HmCi Author: tb Date: 2025/01/11 15:20:23 Move is_on_curve() and (point) cmp() up These were in the middle of the methods responsible for curve operations, which makes little sense. lib/libcrypto/ec/ec_local.h lib/libcrypto/ec/ecp_methods.c commit avx3dX4fTs9qk6th Author: tb Date: 2025/01/11 15:02:42 Move compressed coordinate setting into public API Now that it is method-agnostic, we can remove the method and move the implementation to the body of the public API function. And another method goes away. We're soon down to the ones we really need. discussed with jsing lib/libcrypto/ec/ec_lib.c lib/libcrypto/ec/ec_local.h lib/libcrypto/ec/ecp_methods.c commit CrO4IGywo2FE1Q84 Author: tb Date: 2025/01/11 14:53:46 Rework ec_point_set_compressed_coordinates() While this is nicely done, it is a bit too clever. We can do the calculation in the normal domain rather than the Montgomery domain and this way the method becomes method agnostic. This will be a bit slower but since a couple of field operations are nothing compared to the cost of BN_mod_sqrt() this isn't a concern. ok jsing lib/libcrypto/ec/ecp_methods.c commit NDt5wvXjLB6WDlWt Author: tb Date: 2025/01/11 14:48:20 Move ec_points_make_affine() to the right place discussed with jsing lib/libcrypto/ec/ecp_methods.c commit vvdtyXB5menmmjVl Author: tb Date: 2025/01/11 14:38:57 Move the EC_POINTs API into the garbage bin lib/libcrypto/ec/ec_lib.c commit 4zt0eRq5wEbTI2um Author: tb Date: 2025/01/11 13:58:31 Neuter the EC_POINTs_* API EC_POINTs_mul() was only ever used by Ruby and they stopped doing so for LibreSSL when we incorporated the constant time multiplication work of Brumley et al and restricted the length of the points array to 1, making this API effectively useless. The only real reason you want to have an API to calculate \sum n_i P_i is for ECDSA where you want m * G + n * P. Whether something like his needs to be in the public API is doubtful. EC_POINTs_make_affine() is an implementation detail of EC_POINTs_mul(). As such it never really belonged into the public API. ok jsing lib/libcrypto/ec/ec_lib.c lib/libcrypto/ec/ec_local.h lib/libcrypto/ec/ec_mult.c lib/libcrypto/ec/ecp_methods.c commit MB6x496LOTBGQT9U Author: tb Date: 2025/01/11 13:41:17 Remove a pointless check about Z == 1 ok jsing lib/libcrypto/ec/ec_lib.c commit NnryjXqkKoc34zEf Author: tb Date: 2025/01/11 13:38:42 Inline ec_point_make_affine() in the public API Whatever the EC_METHOD, this will always be equivalent to getting and setting the affine coordinates, so this needs no dedicated method. Also, this is a function that makes no real sense since a caller should never need to care about this... As always, our favorite language bindings thought they might have users who care. This time it's Ruby and Perl. ok jsing lib/libcrypto/ec/ec_lib.c lib/libcrypto/ec/ec_local.h lib/libcrypto/ec/ecp_methods.c commit JVBywauOr8NAAaK6 Author: tb Date: 2025/01/11 03:00:04 Remove seven pairs of unnecessary parentheses ok millert operator(7) lib/libcrypto/asn1/t_x509.c